From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] build: use cat instead of more
Date: Mon, 01 Apr 2019 13:24:20 +0200
Message-ID: <3743424.Qud79MjzIA@xps>
References: <20190401103551.28909-1-alialnu@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
 harini.ramakrishnan@microsoft.com, ranjit.menon@intel.com
To: Ali Alnubani <alialnu@mellanox.com>,
 "bruce.richardson@intel.com" <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id E638D11A4
 for <dev@dpdk.org>; Mon,  1 Apr 2019 13:24:24 +0200 (CEST)
In-Reply-To: <20190401103551.28909-1-alialnu@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/04/2019 12:36, Ali Alnubani:
> This is to fix a build error with meson that is caused
> by using the 'more' command to read the VERSION file. The error:
> 
>     config/meson.build:10:10: ERROR:  String
>     '::::::::::::::\n<RTE_SDK_PATH>VERSION\n::::::::::::::\n19' cannot be
>     converted to int
> 
> The command 'more' prints the file name before the actual
> contents of the file when it's being run without a controlling terminal.
> This could happen in CI environments.
> 
> Please refer to:
> https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/tree/text-utils/more.c
> 
> The cat command can still be found on Windows if the ports of GNU
> utilities are installed.
> 
> Fixes: c04172b5f031 ("build: add single source of DPDK version number")
> Fixes: d320fe56bd51 ("build: use version number from config file")
> 
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

It is fixing a regression on Linux.
I think we should take this fix urgently
and think about Windows in a next step.

"more" is an interactive command, we should not use it.
As suggested by Ali, we may require an extra dependency on Windows
to get some GNU utilities. Or if no other tools are required,
may we have a meson builtin to read a file?