From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v1 1/1] doc: announce ethdev ABI change for
	rte_eth_dev_info.
Date: Thu, 22 Nov 2018 18:15:16 +0100
Message-ID: <3746356.gW38syhklm@xps>
References: <1542888549-24656-1-git-send-email-ian.stokes@intel.com>
 <0abfa3f0-0f58-3265-d156-4d8d9b670830@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
 stephen@networkplumber.org, arybchenko@solarflare.com
To: Ian Stokes <ian.stokes@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1329D1B4AE
 for <dev@dpdk.org>; Thu, 22 Nov 2018 18:15:19 +0100 (CET)
In-Reply-To: <0abfa3f0-0f58-3265-d156-4d8d9b670830@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

22/11/2018 13:11, Ferruh Yigit:
> On 11/22/2018 12:09 PM, Ian Stokes wrote:
> > Maximum and minimum MTU values vary between hardware devices. In
> > hardware agnostic DPDK applications access to such information would
> > allow a more accurate way of validating and setting supported MTU values on
> > a per device basis rather than using a defined default for all devices.
> > 
> > The following solution was proposed:
> > 
> > http://mails.dpdk.org/archives/dev/2018-September/110959.html
> > 
> > This patch adds a depreciation notice for ``rte_eth_dev_info`` as new
> > members will be added to represent min and max MTU values. These can be
> > added to fit a hole in the existing structure for amd64 but not for 32 bit,
> > as such ABI change will occur as size of the structure will be impacted.
> > 
> > Signed-off-by: Ian Stokes <ian.stokes@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

[...]
> > +* ethdev: Maximum and minimum MTU values vary between hardware devices. In
> > +  hardware agnostic DPDK applications access to such information would allow
> > +  a more accurate way of validating and setting supported MTU values on a per
> > +  device basis rather than using a defined default for all devices. To
> > +  resolve this, the following members will be added to ``rte_eth_dev_info``.
> > +  Note: these can be added to fit a hole in the existing structure for amd64
> > +  but not for 32 bit, as such ABI change will occur as size of the structure
> > +  will increase.
> > +
> > +  - Member ``uint16_t min_mtu`` the minimum MTU allowed.
> > +  - Member ``uint16_t max_mtu`` the maximum MTU allowed.
> > +