From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/l3fwd-power: fix Rx descriptor size Date: Mon, 01 May 2017 18:01:29 +0200 Message-ID: <3754229.ISIS8DmyvR@xps> References: <1493206192-69422-1-git-send-email-pablo.de.lara.guarch@intel.com> <2DBBFF226F7CF64BAFCA79B681719D953A19C09D@shsmsx102.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Yao, Lei A" , stable@dpdk.org To: "De Lara Guarch, Pablo" Return-path: In-Reply-To: <2DBBFF226F7CF64BAFCA79B681719D953A19C09D@shsmsx102.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 28/04/2017 09:47, Yao, Lei A: > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Pablo de Lara > > > > L3fwd power app monitors the RX queues to see if the polling frequency > > should be adjusted (the busier the queue, the higher the frequency). > > The app uses several thresholds in the ring to determine the frequency, > > being 96 the highest one, when frequency should be highest. > > > > The problem is that the difference between this value and the ring size > > is not big enough (128 - 96 = 32 descriptors), which means that > > if the descriptors are not replenished quick enough, queue might > > not be busy, but the app would think that it is, because 96th descriptor > > is set. > > > > Therefore, by increasing this gap (increasing the RX ring size), > > we make sure that this false measurement will not happen. > > > > Fixes: b451aa39db31 ("examples/l3fwd-power: use DD bit rather than RX > > queue count") > > Cc: stable@dpdk.org > > > > Signed-off-by: Pablo de Lara > I have test this patch based on 17.05-rc2 , issue is fixed. Host frequency can > be changed according to the data throughput. > Tested-by: Lei Yao (lei.a.yao@intel.com) Applied, thanks