From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 1/2] drivers/mempool: add stack mempool
	handler as driver
Date: Tue, 21 Mar 2017 10:25:48 +0530
Message-ID: <37546ac7-1c60-5992-5ebf-eef8e905017e@nxp.com>
References: <1490004190-16892-1-git-send-email-shreyansh.jain@nxp.com>
 <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <olivier.matz@6wind.com>, <dev@dpdk.org>, <thomas.monjalon@6wind.com>,
 <hemant.agrawal@nxp.com>
To: "Hunt, David" <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0041.outbound.protection.outlook.com [104.47.42.41])
 by dpdk.org (Postfix) with ESMTP id 7584E201
 for <dev@dpdk.org>; Tue, 21 Mar 2017 05:49:53 +0100 (CET)
In-Reply-To: <2fc176b1-a771-f4b5-a08d-1a31f46884d5@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hello David,

On Monday 20 March 2017 08:20 PM, Hunt, David wrote:
>
> On 20/3/2017 10:03 AM, Shreyansh Jain wrote:
>> CONFIG_RTE_DRIVER_MEMPOOL_STACK option added to common_base.
>> Stack mempool handler moved from lib/librte_mempool into drivers/mempool.
>>

<...>

>> -}
>> -
>> -static struct rte_mempool_ops ops_stack = {
>> -    .name = "stack",
>> -    .alloc = stack_alloc,
>> -    .free = stack_free,
>> -    .enqueue = stack_enqueue,
>> -    .dequeue = stack_dequeue,
>> -    .get_count = stack_get_count
>> -};
>> -
>> -MEMPOOL_REGISTER_OPS(ops_stack);
>
> Shreyansh,
>     Could I suggest you add the parameter "--find-renames" when
> generating the patch files, as this will reduce the size of the patches
> significantly, making for easier review. The patch line count in this
> particular case would be reduced by approx 75%.

Thanks for suggestion.
Yes, I forgot to use this option while creating this patch. If there
are comments and v2 needs to be created, I will keep this in mind.

> Regards,
> Dave.
>
>