From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/1] doc: correct Vhost Sample Application guide Date: Wed, 09 Dec 2015 16:09:21 +0100 Message-ID: <3756278.RbTW4O93Bj@xps13> References: <1449664541-9546-1-git-send-email-bernard.iremonger@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Mcnamara, John" Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id E5A79590C for ; Wed, 9 Dec 2015 16:10:37 +0100 (CET) Received: by wmvv187 with SMTP id v187so266594292wmv.1 for ; Wed, 09 Dec 2015 07:10:37 -0800 (PST) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-12-09 14:50, Mcnamara, John: > Also, as a general note, not just to this document/patch. > > I don't think the "user@target:~$" prefixes used in some DPDK > Doc commandlines is useful. > > It prevents a straight copy and paste for testing, it makes the > literal block lines longer than they should be, it isn't used > consistently everywhere, it is visually distracting (in some > cases it is longer than the command being shown), and it isn't > always correct (I presume in the above case of "user@target" you > would need run the application as sudo if you are a non root > user). > > Any objections to removing these as documents are updated? Generally speaking, +1 to remove extra bytes :)