From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3] mk: fix FreeBSD build
Date: Thu, 21 Jul 2016 10:27:54 +0200
Message-ID: <3763917.FNUyifCyb9@xps13>
References: <1468857995-130392-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <1468935637-39937-1-git-send-email-sergio.gonzalez.monroy@intel.com>
 <CAATJJ0LaBF2Q=KMGzBFR7M2=j8JgwWfJ803b9tmbMiYUEDriwA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Christian Ehrhardt <christian.ehrhardt@canonical.com>, dev <dev@dpdk.org>,
 Ferruh Yigit <ferruh.yigit@intel.com>
To: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 06C4C3777
 for <dev@dpdk.org>; Thu, 21 Jul 2016 10:27:57 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id q128so13527215wma.1
 for <dev@dpdk.org>; Thu, 21 Jul 2016 01:27:57 -0700 (PDT)
In-Reply-To: <CAATJJ0LaBF2Q=KMGzBFR7M2=j8JgwWfJ803b9tmbMiYUEDriwA@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > The sed syntax of '0,/regexp/' is GNU specific and fails with
> > non GNU sed in FreeBSD.
> >
> > To solve the issue we can use awk instead to remove duplicates.
> >
> > The awk script basically keeps the last config value, while
> > maintaining order and comments from original config file.
> >
> > Fixes: b2063f104db7 ("mk: filter duplicate configuration entries")
> >
> > Signed-off-by: Sergio Gonzalez Monroy <sergio.gonzalez.monroy@intel.com>
> 
> Hi,
> the order changed, but IMHO actually it improved.
> Things are now at the place they were before, but with the overwriting
> config value that came later - that is the best of both worlds.
> 
> Tested a few config runs pre/post patch and compared them sorted (equal)
> and unsorted - now configs slotted in where they belong.
> Thanks for updating Sergio
> 
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

Applied, thanks