From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 0/6] remove unncessary void cast Date: Mon, 11 Sep 2017 13:44:28 +0100 Message-ID: <37f971b8-cae3-f486-a6d4-ff00bfab99a6@intel.com> References: <20170823154445.19494-1-stephen@networkplumber.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Thomas Monjalon To: Stephen Hemminger , dev@dpdk.org Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 19D2C6D45 for ; Mon, 11 Sep 2017 14:44:30 +0200 (CEST) In-Reply-To: <20170823154445.19494-1-stephen@networkplumber.org> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/23/2017 4:44 PM, Stephen Hemminger wrote: > There are many places that cast away the return value from > rte_memcpy(). This was a common practice in the Unix BSD days because > lint would complain about unused return values, but it is not done > in modern Linux style because it clutters the code. > > Maybe it was done for some Coverity warnings. If so, that issue > should be addressed with Coverity overrides not more code clutter. > > Stephen Hemminger (6): > testpmd: remove unnecessary void casts > bnx2x: remove unnecssary void cast of rte_memcpy > sfc: remove unnecessary cast of rte_memcpy > e1000: remove unnecessary cast of rte_memcpy > i40e: remove unnecessary cast of rte_memcpy > ixgbe: remove unnecessary cast of rte_memcpy My concern is if coverity complains about return value not checked and someone starts fixing them adding void casts back. So I will evaluate the patchset for next-net, so that I can run coverity on them before merged into main tree, and see the result.