From: fengchengwen <fengchengwen@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Kevin Traynor <ktraynor@redhat.com>, <dev@dpdk.org>,
<stable@dpdk.org>, Aman Singh <aman.deep.singh@intel.com>
Subject: Re: [PATCH 3/4] app/testpmd: check for no arguments
Date: Fri, 13 Mar 2026 07:59:08 +0800 [thread overview]
Message-ID: <37ff0e85-3f46-4b51-bf56-5d03b4910fac@huawei.com> (raw)
In-Reply-To: <20260312100317.5b06a849@phoenix.local>
On 3/13/2026 1:03 AM, Stephen Hemminger wrote:
> On Thu, 12 Mar 2026 20:37:42 +0800
> fengchengwen <fengchengwen@huawei.com> wrote:
>
>> Hi Kevin,
>>
>> On 3/12/2026 6:36 PM, Kevin Traynor wrote:
>>> For the case where token is NULL, there are no arguments
>>> and split_str[0] is used uninitialized.
>>
>> In which case the token is NULL, if there are no arguments, the cmdline's
>> callback won't be invoke.
>>
>> Thanks
>
> It still maybe possible to get there with an empty string ""
> which would evaluate to no arguments?
No, as tested below:
testpmd> port config dcb vt on 4 pfc ""
Bad arguments
testpmd> port config dcb vt on 4 pfc ''
Bad arguments
testpmd> port config dcb vt on 4 pfc '
Bad arguments
testpmd> port config dcb vt on 4 pfc
Bad arguments
next prev parent reply other threads:[~2026-03-12 23:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 10:36 [PATCH 0/4] Static analysis fixes Kevin Traynor
2026-03-12 10:36 ` [PATCH 1/4] vhost: fix resource leak Kevin Traynor
2026-03-17 14:46 ` Maxime Coquelin
2026-03-12 10:36 ` [PATCH 2/4] net/bnxt: fix uninitialized read Kevin Traynor
2026-03-12 16:57 ` Stephen Hemminger
2026-03-16 18:39 ` Thomas Monjalon
2026-03-12 18:45 ` Kishore Padmanabha
2026-03-12 10:36 ` [PATCH 3/4] app/testpmd: check for no arguments Kevin Traynor
2026-03-12 12:37 ` fengchengwen
2026-03-12 17:03 ` Stephen Hemminger
2026-03-12 23:59 ` fengchengwen [this message]
2026-03-13 9:24 ` Kevin Traynor
2026-03-14 7:57 ` fengchengwen
2026-03-16 9:47 ` Kevin Traynor
2026-03-12 10:36 ` [PATCH 4/4] app/testpmd: fix fd leak Kevin Traynor
2026-03-17 15:52 ` Thomas Monjalon
2026-03-17 15:55 ` [PATCH 0/4] Static analysis fixes Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37ff0e85-3f46-4b51-bf56-5d03b4910fac@huawei.com \
--to=fengchengwen@huawei.com \
--cc=aman.deep.singh@intel.com \
--cc=dev@dpdk.org \
--cc=ktraynor@redhat.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox