From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] devtools: add script to find duplicated includes Date: Sat, 15 Jul 2017 11:44:27 +0200 Message-ID: <38475944.HgsPK1xuzd@xps> References: <20170711185546.26138-2-stephen@networkplumber.org> <64D029E5-9E50-4A2F-90E4-964061FEA8B3@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: stephen@networkplumber.org, dev@dpdk.org To: "Wiles, Keith" Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6D8D923D for ; Sat, 15 Jul 2017 11:44:30 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/07/2017 20:43, Wiles, Keith: > > On Jul 14, 2017, at 1:39 PM, Wiles, Keith wrote: > >> On Jul 14, 2017, at 12:07 PM, Thomas Monjalon wr= ote: > >> +cd $(dirname $(readlink -m $0))/.. > >=20 > > I tried the script it works, but I am concerned about the =E2=80=98cd= =E2=80=99 above as it does all of the the repo. I would like to see it do j= ust the directory and sub-directories if a path is given. If I am testing a= specific PMD or library then I would not want to do all of the repo. > >=20 >=20 > I was thinking about something like the following: >=20 > if [ "$1x" =3D "x" ]; then > cd $(dirname $(readlink -m $0))/.. > fi Yes we can add a parameter to the script. The parameter would be the path to check, and the default value is the whole repo. So the script could be used also for another repo - like pktgen ;) I'll send a v2