From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v6 05/10] cryptodev: Initial DPDK Crypto APIs and device framework release Date: Fri, 13 Nov 2015 16:44:24 +0100 Message-ID: <3852910.Ad4h6TD36J@xps13> References: <1447101259-18972-1-git-send-email-declan.doherty@intel.com> <1447176763-19303-1-git-send-email-declan.doherty@intel.com> <1447176763-19303-6-git-send-email-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Declan Doherty Return-path: Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) by dpdk.org (Postfix) with ESMTP id EBF2D9589 for ; Fri, 13 Nov 2015 16:45:38 +0100 (CET) Received: by wmdw130 with SMTP id w130so34229792wmd.0 for ; Fri, 13 Nov 2015 07:45:38 -0800 (PST) In-Reply-To: <1447176763-19303-6-git-send-email-declan.doherty@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-11-10 17:32, Declan Doherty: > +DPDK_2.2 { > + global: > + > + rte_cryptodevs; > + rte_cryptodev_callback_register; > + rte_cryptodev_callback_unregister; > + rte_cryptodev_close; > + rte_cryptodev_count; > + rte_cryptodev_count_devtype; > + rte_cryptodev_configure; > + rte_cryptodev_create_vdev; > + rte_cryptodev_enqueue_burst; > + rte_cryptodev_dequeue_burst; > + rte_cryptodev_get_dev_id; > + rte_cryptodev_info_get; > + rte_cryptodev_session_create; > + rte_cryptodev_session_free; > + rte_cryptodev_socket_id; > + rte_cryptodev_start; > + rte_cryptodev_stats_get; > + rte_cryptodev_stats_reset; > + rte_cryptodev_stop; > + rte_cryptodev_queue_pair_setup; > + rte_cryptodev_queue_pair_start; > + rte_cryptodev_queue_pair_stop; > + rte_cryptodev_queue_pair_count; > + > + rte_cryptodev_pmd_allocate; > + rte_cryptodev_pmd_attach; > + rte_cryptodev_pmd_callback_process; > + rte_cryptodev_pmd_detach; > + rte_cryptodev_pmd_driver_register; > + rte_cryptodev_pmd_get_dev; > + rte_cryptodev_pmd_get_named_dev; > + rte_cryptodev_pmd_is_valid_dev; > + rte_cryptodev_pmd_release_device; > + rte_cryptodev_pmd_socket_id; > + rte_cryptodev_pmd_virtual_dev_init; Why do you split symbold in 2 parts? Some of them are not implemented, e.g. attach() so should be removed. Please keep this list in alphabetical order.