From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/2] Native uio-based PMD for Mellanox ConnectX-3 devices Date: Mon, 06 Jul 2015 16:17:32 +0200 Message-ID: <3865893.mD3C20oiXL@xps13> References: <1436189297-7780-1-git-send-email-dlrmsghd@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: leeopop Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id 09E6A559C for ; Mon, 6 Jul 2015 16:18:42 +0200 (CEST) Received: by widjy10 with SMTP id jy10so162336125wid.1 for ; Mon, 06 Jul 2015 07:18:41 -0700 (PDT) In-Reply-To: <1436189297-7780-1-git-send-email-dlrmsghd@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-07-06 22:28, leeopop: > This is a native UIO-based PMD for Mellanox ConnectX-3 devices. > It uses a persistent memory library in order to provide a persistent > scartch area for the mlx4 HCA driver. What is the benefit of this UIO approach compared to the OFED based driver? > We release the driver itself under BSD license, but to use it for > commercial products, you may have to re-implement the separated GPL sources. The GPL sources are not really separated. The DPDK libraries must be BSD-licensed. > The GPL affected source codes reside in the mlnx_uio/kernel directory. It seems that a large part of the GPL driver was also copied in mlnx_uio/mlnx/. Given that you are dropping a huge GPL codebase (whose you don't own the copyright) in a BSD library, and that you didn't give your real name in the signed-off line, it is NACK.