From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v8 08/10] eal: add minimum viable code for
	eal on windows
Date: Tue, 02 Apr 2019 22:06:06 +0200
Message-ID: <3868443.jK6Cv4ngdr@xps>
References: <20190306041634.12976-1-anand.rawat@intel.com>
 <20190402035458.14664-1-anand.rawat@intel.com>
 <20190402035458.14664-9-anand.rawat@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, pallavi.kadam@intel.com, ranjit.menon@intel.com,
 jeffrey.b.shaw@intel.com, bruce.richardson@intel.com
To: Anand Rawat <anand.rawat@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A93871B107
 for <dev@dpdk.org>; Tue,  2 Apr 2019 22:06:10 +0200 (CEST)
In-Reply-To: <20190402035458.14664-9-anand.rawat@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

02/04/2019 05:54, Anand Rawat:
> Add windows specific logic for eal.c, eal_lcore.c,
> eal_debug.c and eal_thread.c. Updated header files to
> contain suitable function declaractions.
> 
> Signed-off-by: Anand Rawat <anand.rawat@intel.com>
> Signed-off-by: Pallavi Kadam <pallavi.kadam@intel.com>
> Reviewed-by: Jeff Shaw <jeffrey.b.shaw@intel.com>
> Reviewed-by: Ranjit Menon <ranjit.menon@intel.com>
> ---
[...]
> +		/*
> +		 * create communication pipes between master thread
> +		 * and children
> +		 */
> +		if (_pipe(lcore_config[i].pipe_master2slave,
> +			sizeof(char), _O_BINARY) < 0)
> +			rte_panic("Cannot create pipe\n");

rte_panic should be used only in applications, not in libraries.
The application can do something in case of DPDK failure.
Please remove all calls to rte_panic() during next weeks, thanks.