From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] doc: API change notice for librte_meter
Date: Fri, 04 Aug 2017 16:28:46 +0200
Message-ID: <3871111.0JZd9azV8i@xps>
References: <1501852780-191124-1-git-send-email-cristian.dumitrescu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, john.mcnamara@intel.com, jasvinder.singh@intel.com,
 radu.nicolau@intel.com, david.hunt@intel.com
To: Cristian Dumitrescu <cristian.dumitrescu@intel.com>, remy.horton@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 0E96A330D
 for <dev@dpdk.org>; Fri,  4 Aug 2017 16:28:49 +0200 (CEST)
In-Reply-To: <1501852780-191124-1-git-send-email-cristian.dumitrescu@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

04/08/2017 15:19, Cristian Dumitrescu:
> +* librte_meter: The API will change to accommodate configuration profiles.
> +  Most of the API functions will have an additional opaque parameter.

Why?
Why opaque parameter?
If you want to use it with a configuration file, you just have to
implement a configuration file in your application.

Moreover, I already explained my fear of adding this library in DPDK
which is really an application-level statistics lib.

Without more explanations, my vote is a nack.

However I remember there was a promise to merge every metrics libs in one.