dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Wiles,
	Roger Keith"
	<keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] Remove n_orig from __mempool_get_bulk() routine, cleanup  comment.
Date: Thu, 09 Oct 2014 18:46:24 +0200	[thread overview]
Message-ID: <3871468.xmvE5bJmrt@xps13> (raw)
In-Reply-To: <1EEE2DAF-2F00-4B95-A1ED-262FA9E00077-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>

Hi Keith,

2014-10-03 21:27, Wiles, Roger Keith:
> Cleanup the code some to remove n_orig variable that was not required.                                                              
> Update the comments to __mempool_get_bulk to state the correct return value.                                                       
> 
> Signed-off-by: Keith Wiles <keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>                                                                              
[...]
>   * @return
> - *   - >=0: Success; number of objects supplied.
> + *   - 0: Success; number of objects requested.
>   *   - <0: Error; code of ring dequeue function.
>   */
>  static inline int __attribute__((always_inline))
> @@ -945,9 +945,6 @@ __mempool_get_bulk(struct rte_mempool *mp, void **obj_table,
>                    unsigned n, int is_mc)

Please, could you check ret? I think it can be >0.

Formatting comment: title should be
	mempool: remove useless variable
Prefer short title, especially when behavior is not changed.

Thanks
-- 
Thomas

      parent reply	other threads:[~2014-10-09 16:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03 21:27 [PATCH] Remove n_orig from __mempool_get_bulk() routine, cleanup comment Wiles, Roger Keith
     [not found] ` <1EEE2DAF-2F00-4B95-A1ED-262FA9E00077-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org>
2014-10-09 16:46   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3871468.xmvE5bJmrt@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=keith.wiles-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).