From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/1] bonding: fix error handling in rte_eth_bond_create() Date: Wed, 05 Aug 2015 15:35:04 +0200 Message-ID: <3872346.WHI1RvlFCy@xps13> References: <1438778204-8896-1-git-send-email-bernard.iremonger@intel.com> <1514392.p4W8R5bZo1@xps13> <8CEF83825BEC744B83065625E567D7C219F36EA6@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Iremonger, Bernard" Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by dpdk.org (Postfix) with ESMTP id 6954A5323 for ; Wed, 5 Aug 2015 15:36:21 +0200 (CEST) Received: by wibhh20 with SMTP id hh20so24675424wib.0 for ; Wed, 05 Aug 2015 06:36:20 -0700 (PDT) In-Reply-To: <8CEF83825BEC744B83065625E567D7C219F36EA6@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-08-05 13:19, Iremonger, Bernard: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > 2015-08-05 13:36, Bernard Iremonger: > > > if the name parameter to rte_eth_bond_create() was NULL, there was a > > > segmentation fault because eth_dev was also NULL. > > > > You also add error handling of mac_addrs alloc and release_port(). > > It deserves to be said in this commit message. > > Will I send a v3 patch ? My comment was mostly to show which kind of information may be useful. Sometimes I write it myself. You are welcome to write it in order I add it or you can send a v3. Other note: the function names are avoided in commit titles as they are redundant with the title prefix and not so easy to read. The title could be bonding: fix crash on initialization error or, to include other fixes, bonding: fix device initialization error handling Thanks