From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] ethtool: add new library to provide ethtool-alike APIs Date: Tue, 02 Jun 2015 18:02:50 +0200 Message-ID: <38737329.jBeOYmBEyN@xps13> References: <1432927612-12244-1-git-send-email-liang-min.wang@intel.com> <3076202.B6CvAKP4DR@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: "Wang, Liang-min" Return-path: Received: from mail-wi0-f169.google.com (mail-wi0-f169.google.com [209.85.212.169]) by dpdk.org (Postfix) with ESMTP id D75E3C33A for ; Tue, 2 Jun 2015 18:03:38 +0200 (CEST) Received: by wizo1 with SMTP id o1so150603705wiz.1 for ; Tue, 02 Jun 2015 09:03:38 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2015-06-02 15:47, Wang, Liang-min: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > >>I'm curious to understand how renaming rte_eth_dev_set_mtu() to > > >>rte_ethtool_net_change_mtu() will help anyone. > >> > >> As described, this interface is designed to provide API closely to kernel space ethtool ops and net_device_op. > > >But the application still needs to adapt the code to call rte_* functions. > >So changing to rte_ethtool_net_change_mtu is equivalent to change to the existing rte_eth_dev_set_mtu. I don't see the benefit. > > The benefit is single interface for users to access. Instead of looking into two different interfaces (ethtool, ether). Sorry it doesn't help to understand. Today, there is an ethdev API. Why adding an ethtool-like API would help?