From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v6 1/8] stack: introduce rte stack library
Date: Wed, 03 Apr 2019 19:23:33 +0200
Message-ID: <3878276.WNQnuX6GrZ@xps>
References: <20190401001238.17625-1-gage.eads@intel.com>
 <5912114.tna7mvfDTn@xps>
 <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 "olivier.matz@6wind.com" <olivier.matz@6wind.com>,
 "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, "Ananyev,
 Konstantin" <konstantin.ananyev@intel.com>,
 "Gavin Hu (Arm Technology China)" <Gavin.Hu@arm.com>, nd <nd@arm.com>
To: "Eads, Gage" <gage.eads@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 551221B4D3
 for <dev@dpdk.org>; Wed,  3 Apr 2019 19:23:37 +0200 (CEST)
In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E5421054F@FMSMSX108.amr.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

03/04/2019 19:13, Eads, Gage:
> > 02/04/2019 13:14, Honnappa Nagarahalli:
> > > > Subject: [PATCH v6 1/8] stack: introduce rte stack library
> > > >
> > > > The rte_stack library provides an API for configuration and use of a
> > > > bounded stack of pointers. Push and pop operations are MT-safe,
> > > > allowing concurrent access, and the interface supports pushing and
> > > > popping multiple pointers at a time.
> > > >
> > > > The library's interface is modeled after another DPDK data
> > > > structure, rte_ring, and its lock-based implementation is derived
> > > > from the stack mempool handler. An upcoming commit will migrate the
> > > > stack mempool handler to rte_stack.
> > > >
> > > > Signed-off-by: Gage Eads <gage.eads@intel.com>
> > > > Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
> > > > ---
> > > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > 
> > It does not compile for Arm:
> > 
> > lib/librte_stack/rte_stack_std.h:
> > 	In function '__rte_stack_std_pop':
> > lib/librte_stack/rte_stack_std.h:68:6: error:
> > 	implicit declaration of function 'unlikely'
> 
> Missing rte_branch_prediction.h include -- I'll fix and resubmit. Thanks for checking the non-x86 builds.
> 
> I can hold off resubmission until the 128-bit CAS patch is merged, so this series is properly tested in the automated build + test pipeline, if you'd prefer.

Yes, would be the best.
But we need to merge everything tomorrow at last.