From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] Make the thash library arch-independent
Date: Tue, 28 Jul 2015 18:05:26 +0200
Message-ID: <3885263.OLndnQdN2M@xps13>
References: <1438088792-16344-1-git-send-email-medvedkinv@gmail.com>
 <1831659.nSDl63dTav@xps13>
 <CANDrEHnA8DP5wRbeAp-E+hTMieLb8=_xOWjB5A74Na+DG0jhCg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Vladimir Medvedkin <medvedkinv@gmail.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com
 [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id DF61FC44E
 for <dev@dpdk.org>; Tue, 28 Jul 2015 18:06:42 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so166480540wib.0
 for <dev@dpdk.org>; Tue, 28 Jul 2015 09:06:42 -0700 (PDT)
In-Reply-To: <CANDrEHnA8DP5wRbeAp-E+hTMieLb8=_xOWjB5A74Na+DG0jhCg@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-28 18:33, Vladimir Medvedkin:
> 2015-07-28 16:47 GMT+03:00 Thomas Monjalon <thomas.monjalon@6wind.com>:
> > 2015-07-28 09:06, Vladimir Medvedkin:
> > Please explain how it was broken and how you fixed it.
> > It would be interesting to know which part is __SSE3__ and __SSE__.
> >
>  As mentioned in http://dpdk.org/ml/archives/dev/2015-July/022020.html
> compilation fails on non x86 architectures( in that case it was tile). So I
> add for optimized code, which uses SSE3 intrinsics, non optimized general
> version.

I know. I was requesting an updated commit with explanations:
	build is broken because...
	x86 version uses SSE3...
	Some code is enclosed with __SSE__, not __SSE3__ because...

What happens if it is built with SSE3 support but run on
a CPU without such support?
Please check how it is done for ACL.

> > > +#ifdef __SSE3__
> > > +#include <rte_vect.h>
> > > +#endif /* __SSE3__ */
> >
> > Comments after short ifdef block are not needed.
> >
> Should I delete it?

Yes please.

> > > +#ifndef XMM_SIZE
> > > +#define XMM_SIZE     16
> >
> > Why is it needed?
> >
>  because there is no defines for XMM_SIZE on non X86 architectures

Why XMM_SIZE is needed on non x86 arch?