From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH v2 2/5] vhost: make message handling functions prepare the reply Date: Mon, 10 Sep 2018 17:08:20 +0200 Message-ID: <388d5624-15e3-13f1-2fae-153a9581b407@redhat.com> References: <153202755842.21481.1772155561595981441.stgit@T460> <153202761415.21481.4698894052167645234.stgit@T460> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Nikolay Nikolaev , tiwei.bie@intel.com, zhihong.wang@intel.com Return-path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 21ACF4C91 for ; Mon, 10 Sep 2018 17:08:24 +0200 (CEST) In-Reply-To: <153202761415.21481.4698894052167645234.stgit@T460> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > As VhostUserMsg structure is resued to generate the reply, move the s/resued/reused/ > relevant fields update into the respective message handling functions. > > Signed-off-by: Nikolay Nikolaev > --- > lib/librte_vhost/vhost_user.c | 26 ++++++++++++++++---------- > 1 file changed, 16 insertions(+), 10 deletions(-) > Agree this is cleaner: Reviewed-by: Maxime Coquelin For the typo, don't resend the series just for this if this is the only thing to fix. I suspect a rebase may be required anyway as it may conflict with a patch from Ilya. Thanks, Maxime