From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] kni: use netif_rx instead of
	netif_receive_skb in which ocurr deallock on userpace contex
Date: Fri, 11 Jul 2014 09:45:20 +0200
Message-ID: <39030235.AJ30siSIub@xps13>
References: <1405011865-26028-1-git-send-email-blue119@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Yao-Po Wang <blue119-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1405011865-26028-1-git-send-email-blue119-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

Hi,

Thank you for sending this patch.
Please, could you re-send it with a more detailed explanation and a
Signed-off-by line?

There is a how-to for patch contributions here:
	http://dpdk.org/dev#send


2014-07-11 01:04, Yao-Po Wang:
> ---
>  lib/librte_eal/linuxapp/kni/kni_net.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/linuxapp/kni/kni_net.c
> b/lib/librte_eal/linuxapp/kni/kni_net.c index d3c0190..28cc5ab 100644
> --- a/lib/librte_eal/linuxapp/kni/kni_net.c
> +++ b/lib/librte_eal/linuxapp/kni/kni_net.c
> @@ -179,7 +179,7 @@ kni_net_rx_normal(struct kni_dev *kni)
>  			skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
>  			/* Call netif interface */
> -			netif_receive_skb(skb);
> +			netif_rx(skb);
> 
>  			/* Update statistics */
>  			kni->stats.rx_bytes += len;