From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4] examples/qos_sched: fix bad bit shift
	operation
Date: Mon, 16 May 2016 18:34:10 +0200
Message-ID: <3903086.2L5T4XfrGH@xps13>
References: <1462956485-3701-1-git-send-email-slawomirx.mrozowicz@intel.com>
 <3EB4FA525960D640B5BDFFD6A3D89126479BB334@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>, "Mrozowicz,
 SlawomirX" <slawomirx.mrozowicz@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 7C06A6CA2
 for <dev@dpdk.org>; Mon, 16 May 2016 18:34:12 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id g17so145017982wme.1
 for <dev@dpdk.org>; Mon, 16 May 2016 09:34:12 -0700 (PDT)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479BB334@IRSMSX108.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

> > Subject: [PATCH v4] examples/qos_sched: fix bad bit shift operation

Slawomir, please use --in-reply-to when sending a new revision,
to let us see the full history in our mailer and in the archives.

[...]
> > diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
> > index 3e7fd08..354372d 100644
> > --- a/examples/qos_sched/args.c
> > +++ b/examples/qos_sched/args.c
> > @@ -123,7 +123,7 @@ app_eal_core_mask(void)
> >  	uint64_t cm = 0;
> >  	struct rte_config *cfg = rte_eal_get_configuration();
> > 
> > -	for (i = 0; i < RTE_MAX_LCORE; i++) {
> > +	for (i = 0; i < APP_MAX_LCORE; i++) {
> >  		if (cfg->lcore_role[i] == ROLE_RTE)
> >  			cm |= (1ULL << i);
> >  	}
> > @@ -142,7 +142,7 @@ app_cpu_core_count(void)
> >  	char path[PATH_MAX];
> >  	uint32_t ncores = 0;
> > 
> > -	for(i = 0; i < RTE_MAX_LCORE; i++) {
> > +	for (i = 0; i < APP_MAX_LCORE; i++) {
> >  		len = snprintf(path, sizeof(path), SYS_CPU_DIR, i);
> >  		if (len <= 0 || (unsigned)len >= sizeof(path))
> >  			continue;
> > diff --git a/examples/qos_sched/main.h b/examples/qos_sched/main.h
> > index 82aa0fa..c7490c6 100644
> > --- a/examples/qos_sched/main.h
> > +++ b/examples/qos_sched/main.h
> > @@ -68,7 +68,10 @@ extern "C" {
> > 
> >  #define BURST_TX_DRAIN_US 100
> > 
> > -#define MAX_DATA_STREAMS (RTE_MAX_LCORE/2)
> > +#ifndef APP_MAX_LCORE
> > +#define APP_MAX_LCORE 64
> > +#endif
> > +#define MAX_DATA_STREAMS (APP_MAX_LCORE/2)
> >  #define MAX_SCHED_SUBPORTS		8
> >  #define MAX_SCHED_PIPES		4096
> > 
> > --
> > 1.9.1
> 
> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>

Cristian, please remove patch content when acking.
My hand is tired of scrolling ;)