From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 05/11] ethdev: add probing finish function Date: Thu, 10 May 2018 12:54:57 +0200 Message-ID: <3910255.F1yzIlvK5u@xps> References: <20180509094337.26112-1-thomas@monjalon.net> <20180509224313.27289-6-thomas@monjalon.net> <0b071bfa-29e0-b014-1991-ef500b870a07@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Andrew Rybchenko Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 188991BA4B for ; Thu, 10 May 2018 12:54:59 +0200 (CEST) In-Reply-To: <0b071bfa-29e0-b014-1991-ef500b870a07@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2018 12:37, Andrew Rybchenko: > On 05/10/2018 01:43 AM, Thomas Monjalon wrote: > > A new hook function is added and called inside the PMDs at the end > > of the device probing: > > - in primary process, after allocating, init and config > > - in secondary process, after attaching and local init > > > > This new function is almost empty for now. > > It will be used later to add some post-initialization processing. > > > > For the PMDs calling the helpers rte_eth_dev_create() or > > rte_eth_dev_pci_generic_probe(), the hook rte_eth_dev_probing_finish() > > is called from here, and not in the PMD itself. > > > > Note that the helper rte_eth_dev_create() could be used more, > > especially for vdevs, avoiding some code duplication in PMDs. > > > > Cc: stable@dpdk.org > > Why Cc? Because other fixes in the series depend on this patch.