From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/ixgbe: fix compilation when vector
	driver disabled
Date: Mon, 16 Apr 2018 18:57:55 +0200
Message-ID: <3918223.XbEGDHI6z0@xps>
References: <20180416133911.289196-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org, wenzhuo.lu@intel.com
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 7366EAADA
 for <dev@dpdk.org>; Mon, 16 Apr 2018 18:57:58 +0200 (CEST)
In-Reply-To: <20180416133911.289196-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

16/04/2018 15:39, Bruce Richardson:
> The new functions for Rx and Tx offloads should not be inside the
> conditional block for the vector driver, otherwise compile errors occur
> when vector driver is disabled. For example:
>=20
>   ixgbe_ethdev.c:3636:36: error: implicit declaration of function =E2=80=
=98ixgbe_get_rx_queue_offloads=E2=80=99;
>=20
> This shows up as an error when doing ARM builds using meson as the vector
> driver is not (yet) enabled for those builds.
>=20
> Fixes: 51215925a32f ("net/ixgbe: convert to new Tx offloads API")
> Fixes: ec3b1124d14d ("net/ixgbe: convert to new Rx offloads API")
>=20
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks