From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] mempool: fix check flags Date: Thu, 8 Sep 2016 15:44:44 +0100 Message-ID: <39302a3a-9662-7f75-db3b-e7dd4244c32f@intel.com> References: <1473344895-18491-1-git-send-email-h.mikita89@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Hiroyuki Mikita , olivier.matz@6wind.com Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id D351A37A8 for ; Thu, 8 Sep 2016 16:44:46 +0200 (CEST) In-Reply-To: <1473344895-18491-1-git-send-email-h.mikita89@gmail.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2016 3:28 PM, Hiroyuki Mikita wrote: > fix check flags in case of single producer and single consumer > > Fixes: 449c49b9 ("mempool: support handler operations") > > Signed-off-by: Hiroyuki Mikita > --- > lib/librte_mempool/rte_mempool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c > index 2e28e2e..61bd63c 100644 > --- a/lib/librte_mempool/rte_mempool.c > +++ b/lib/librte_mempool/rte_mempool.c > @@ -879,7 +879,7 @@ rte_mempool_create(const char *name, unsigned n, unsigned elt_size, > * Since we have 4 combinations of the SP/SC/MP/MC examine the flags to > * set the correct index into the table of ops structs. > */ > - if (flags & (MEMPOOL_F_SP_PUT | MEMPOOL_F_SC_GET)) > + if ((flags & MEMPOOL_F_SP_PUT) & (flags & MEMPOOL_F_SC_GET)) Isn't this always false? What about: if ((flags & MEMPOOL_F_SP_PUT) && (flags & MEMPOOL_F_SC_GET)) > rte_mempool_set_ops_byname(mp, "ring_sp_sc", NULL); > else if (flags & MEMPOOL_F_SP_PUT) > rte_mempool_set_ops_byname(mp, "ring_sp_mc", NULL); >