From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH 3/7] ethdev: separate driver APIs
Date: Fri, 1 Dec 2017 14:29:01 +0530
Message-ID: <393b75b1-bc37-3aeb-a63b-f33abff546bc@nxp.com>
References: <20171201022957.64329-1-ferruh.yigit@intel.com>
 <20171201022957.64329-3-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <vladz@cloudius-systems.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Thomas Monjalon
 <thomas@monjalon.net>, Shreyansh Jain <shreyansh.jain@nxp.com>, Nipun Gupta
 <nipun.gupta@nxp.com>, Jerin Jacob <jerin.jacob@caviumnetworks.com>, Santosh
 Shukla <santosh.shukla@caviumnetworks.com>, "John W. Linville"
 <linville@tuxdriver.com>, Shepard Siegel <shepard.siegel@atomicrules.com>, Ed
 Czeck <ed.czeck@atomicrules.com>, John Miller <john.miller@atomicrules.com>,
 Allain Legacy <allain.legacy@windriver.com>, Matt Peters
 <matt.peters@windriver.com>, Harish Patil <harish.patil@cavium.com>, Rasesh
 Mody <rasesh.mody@cavium.com>, Stephen Hurd <stephen.hurd@broadcom.com>, Ajit
 Khaparde <ajit.khaparde@broadcom.com>, Declan Doherty
 <declan.doherty@intel.com>, Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Marcin Wojtas <mw@semihalf.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM02-BL2-obe.outbound.protection.outlook.com
 (mail-bl2nam02on0042.outbound.protection.outlook.com [104.47.38.42])
 by dpdk.org (Postfix) with ESMTP id DF6D73255
 for <dev@dpdk.org>; Fri,  1 Dec 2017 09:59:12 +0100 (CET)
In-Reply-To: <20171201022957.64329-3-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/1/2017 7:59 AM, Ferruh Yigit wrote:

<snip>...
> diff --git a/lib/librte_ether/rte_ethdev_driver.h b/lib/librte_ether/rte_ethdev_driver.h
> new file mode 100644
> index 000000000..3e77d1439
> --- /dev/null
> +++ b/lib/librte_ether/rte_ethdev_driver.h
> @@ -0,0 +1,163 @@
> +/*-
> + *   BSD LICENSE
> + *
> + *   Copyright(c) 2017 Intel Corporation. All rights reserved.
> + *   All rights reserved.

You can remove one of the all rights reserved.
This is also an issue in your next patch for rte_ethdev_core.h

Also, as Shreyansh mentioned, Why not start with SPDX tags instead of 
full license text?

<snip>...
> +/**
> + * @internal Executes all the user application registered callbacks for
> + * the specific device. It is for DPDK internal user only. User
> + * application should not call it directly.
> + *
> + * @param dev
> + *  Pointer to struct rte_eth_dev.
> + * @param event
> + *  Eth device interrupt event type.
> + * @param cb_arg
> + *  callback parameter.
> + * @param ret_param
> + *  To pass data back to user application.
> + *  This allows the user application to decide if a particular function
> + *  is permitted or not.
> + *
> + * @return
> + *  int
> + */
> +int _rte_eth_dev_callback_process(struct rte_eth_dev *dev,
> +		enum rte_eth_event_type event, void *cb_arg, void *ret_param);
> +
> +/**
> + * Create memzone for HW rings.

Like all other functions, you can also add "@internal" for this as well.

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>