From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 0/4] Fixes for coverity issues in fbarray Date: Mon, 23 Apr 2018 22:16:38 +0200 Message-ID: <3940059.fMP8snkLnf@xps> References: <20180418085139.GN4957@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Adrien Mazarguil To: Anatoly Burakov Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 5048F10B7 for ; Mon, 23 Apr 2018 22:16:41 +0200 (CEST) In-Reply-To: <20180418085139.GN4957@6wind.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 18/04/2018 10:51, Adrien Mazarguil: > On Tue, Apr 17, 2018 at 04:44:04PM +0100, Anatoly Burakov wrote: > > This patchset fixes a number of Coverity issues introduced > > in recent DPDK memory hotplug patchset. > > > > Coverity issues fixed: > > - 272564 - error condition not checked > > - 272579 - dereference before null check > > - 272586 - error condition not checked > > > > There are two additional issues reported by coverity: > > - 272598 - error condition not checked > > - 272599 - error condition not checked > > > > However, they are fixed by a separate patch [1]. > > > > [1] http://dpdk.org/dev/patchwork/patch/38091/ > > > > Anatoly Burakov (4): > > fbarray: use strlcpy instead of snprintf > > fbarray: add check for failed file descriptor open > > fbarray: fix potential null-dereference > > fbarray: handle negative return > > Given that I recently addressed a similar issue in fbarray as well: > > Acked-by: Adrien Mazarguil Applied, thanks