From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] igb_uio: fix uevent montior issue
Date: Mon, 12 Feb 2018 10:46:56 +0100
Message-ID: <3951509.LRgmqiM9ue@xps>
References: <1517306475-2153-1-git-send-email-jia.guo@intel.com>
 <10497764.pzdNBqvViL@xps> <899b1116-cf19-249e-cc55-8993ef7729e6@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: ferruh.yigit@intel.com, dev@dpdk.org, jingjing.wu@intel.com,
 jianfeng.tan@intel.com
To: "Guo, Jia" <jia.guo@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 621861B026
 for <dev@dpdk.org>; Mon, 12 Feb 2018 10:47:06 +0100 (CET)
In-Reply-To: <899b1116-cf19-249e-cc55-8993ef7729e6@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

12/02/2018 09:28, Guo, Jia:
> 
> On 2/9/2018 6:01 AM, Thomas Monjalon wrote:
> > 30/01/2018 11:01, Jeff Guo:
> >> udev could not detect remove and add event of device when hotplug in
> >> and out devices, that related with the fix about using pointer of
> >> rte_uio_pci_dev as dev_id instead of uio_device for irq device handler,
> >> that would result igb uio irq failure when kernel version after than 3.17.
> >> so this patch correct it by use kernel version check before handle the
> >> pci interrupt.
> >>
> >> Fixes: 6b9ed026a870 ("igb_uio: fix build with kernel <= 3.17")
> >> Signed-off-by: Jeff Guo <jia.guo@intel.com>
> >> ---
> >> +#if LINUX_VERSION_CODE < KERNEL_VERSION(3, 17, 0)
> >>   	struct rte_uio_pci_dev *udev = (struct rte_uio_pci_dev *)dev_id;
> >>   	struct uio_info *info = &udev->info;
> >> -
> >> +#else
> >> +	struct uio_device *idev = (struct uio_device *)dev_id;
> >> +	struct uio_info *info = idev->info;
> >> +	struct rte_uio_pci_dev *udev = info->priv;
> >> +#endif
> > Can we avoid checking Linux version number?
> > This method won't work with kernel backports.
> i don't think that is a bug rather than a kernel feature parameter 
> change , so i am not sure if it will definitely a chance exist for the 
> kernel backport fix for that.

Features are also backported in some kernels.