From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [dpdk-stable] [PATCH] mk: use ?= instead of := for
	RTE_DEVEL_BUILD
Date: Fri, 23 Sep 2016 18:29:18 +0200
Message-ID: <3978773.PpqE2HOjj0@xps13>
References: <1473850242-29734-1-git-send-email-lboccass@brocade.com>
 <CAATJJ0+BMZ3Oc7=ugNSBghei_Wq-J+m-fUA3P=iRRAYDd9pjnA@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: stable@dpdk.org, Christian Ehrhardt <christian.ehrhardt@canonical.com>,
 dev <dev@dpdk.org>
To: Luca Boccassi <lboccass@brocade.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51])
 by dpdk.org (Postfix) with ESMTP id 93CCD68F8
 for <dev@dpdk.org>; Fri, 23 Sep 2016 18:29:24 +0200 (CEST)
Received: by mail-wm0-f51.google.com with SMTP id b130so39425680wmc.0
 for <dev@dpdk.org>; Fri, 23 Sep 2016 09:29:24 -0700 (PDT)
In-Reply-To: <CAATJJ0+BMZ3Oc7=ugNSBghei_Wq-J+m-fUA3P=iRRAYDd9pjnA@mail.gmail.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-09-14 12:54, Christian Ehrhardt:
> On Wed, Sep 14, 2016 at 12:50 PM, Luca Boccassi <lboccass@brocade.com>
> wrote:
> 
> > RTE_DEVEL_BUILD is set to := y in mk/rte.vars.mk, which makes it
> > impossible to override via an environment variable, and forces users
> > to pass it inline in the make call.
> > Use ?= instead to have it pick up the environment variable as well.
> >
> > Cc: <stable@dpdk.org>
> > Signed-off-by: Luca Boccassi <lboccass@brocade.com>
> 
> Acked-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>

I'm surprised you need to pass it via an environment variable.

Applied, thanks