From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: allow updates to build config on make install Date: Wed, 14 May 2014 12:33:46 +0200 Message-ID: <3983181.2kuc6T3mxt@xps13> References: <1400062955-27338-1-git-send-email-bruce.richardson@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Bruce Richardson Return-path: In-Reply-To: <1400062955-27338-1-git-send-email-bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Bruce 2014-05-14 11:22, Bruce Richardson: > There was an issue with rebuilding the code following a change to > one of the config files inside the "config" directory. If one did > a "make install T=" and then made a modification to the > defconfig_ file (or applied a patch which modified that file) > a subsequent re-run of the make install command would not rebuild > the .config file leading to either build failures or an incorrect > build. This change fixes that issue. Your patch is reverting this one: mk: in install rule, don't overwrite .config if it already exists http://dpdk.org/browse/dpdk/commit/?id=1c858a7dfebd4e4092eb55 As stated in the commit log, "This allows the user to prepare a configuration with make config before using make install." So your patch is introducing a regression. I think you are describing something which is not a bug. If you make a modification to the configuration template, you must explicitly call "make config". -- Thomas