From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] eal/linuxapp: Add parameter to specify
	master lcore id
Date: Tue, 04 Nov 2014 20:00:58 +0100
Message-ID: <3986981.sR7Aq8MzkS@xps13>
References: <1404808110-16314-1-git-send-email-simon.kuenzer@neclab.eu>
 <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A@arbor.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Aaron Campbell <aaron-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <582DA5F6-0A84-4FDD-8DC6-D8E5C6B1652A-rd7evPjynkNeoWH0uzbU5w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-11-03 13:02, Aaron Campbell:
> > On Jul 8, 2014, at 5:28 AM, Simon Kuenzer <simon.kuenzer-kcmmt4fgdiuHXe+LvDLADg@public.gmane.org>=
 wrote:
> >=20
> > +=09=09=09else if (!strcmp(lgopts[option_index].name, OPT_MASTER_LC=
ORE)) {
> > +=09=09=09=09if (!coremask_ok) {
> > +=09=09=09=09=09RTE_LOG(ERR, EAL, "please specify the master "
> > +=09=09=09=09=09=09=09"lcore id after specifying "
> > +=09=09=09=09=09=09=09"the coremask\n");
> > +=09=09=09=09=09eal_usage(prgname);
> > +=09=09=09=09=09return -1;
> > +=09=09=09=09}
>=20
>=20
> Hi Simon,
>=20
> I think that forcing a particular command line order is not that clea=
n.
> It might be better to remove the cfg->master_lcore setting from
> eal_parse_coremask(), and defer the selection of the master lcore unt=
il
> all of the command-line options have been parsed.  If =E2=80=94master=
-lcore was
> specified, save the value and use that, otherwise
> rte_get_next_lcore(-1, 0, 0) can return the first bit set in the core=
mask.

It's not sufficient: eal_parse_master_lcore() requires cfg->lcore_role
to be set. There is a real dependency between these 2 options.
I'm going to submit a v2. Feel free to improve it with another patch.

--=20
Thomas