From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 00/32] net/qede: update qede pmd to
	1.2.0.1 and enable by default
Date: Wed, 26 Oct 2016 17:20:18 +0200
Message-ID: <39933081.0D9pxCKPPb@xps13>
References: <1476850306-2141-1-git-send-email-rasesh.mody@qlogic.com>
 <20161024134150.GB27760@bricha3-MOBL3.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Dept-EngDPDKDev@qlogic.com, ferruh.yigit@intel.com
To: Rasesh Mody <rasesh.mody@qlogic.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-lf0-f53.google.com (mail-lf0-f53.google.com
 [209.85.215.53]) by dpdk.org (Postfix) with ESMTP id 5AB4EBB86
 for <dev@dpdk.org>; Wed, 26 Oct 2016 17:20:21 +0200 (CEST)
Received: by mail-lf0-f53.google.com with SMTP id t133so8539968lff.6
 for <dev@dpdk.org>; Wed, 26 Oct 2016 08:20:21 -0700 (PDT)
In-Reply-To: <20161024134150.GB27760@bricha3-MOBL3.ger.corp.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-10-24 14:41, Bruce Richardson:
> On Tue, Oct 18, 2016 at 09:11:14PM -0700, Rasesh Mody wrote:
> > Please apply to DPDK tree for v16.11 release.
> 
> Patchset applied to dpdk_next_net/rel_16_11

It breaks compilation because it is enabled everywhere
and zlib.h is still included without checking CONFIG_ECORE_ZIPPED_FW.
The patch removing zlib dependency was not tested without zlib installed.
I will fix it while applying with this change:

--- a/drivers/net/qede/base/bcm_osal.c
+++ b/drivers/net/qede/base/bcm_osal.c
@@ -6,7 +6,9 @@
  * See LICENSE.qede_pmd for copyright and licensing details.
  */
 
+#ifdef CONFIG_ECORE_ZIPPED_FW
 #include <zlib.h>
+#endif
 
 #include <rte_memzone.h>
 #include <rte_errno.h>


I won't do any quality review of qede patches but from what I've seen before,
there is some room for improvements.

Another nit, important to help reviews, please use --in-reply-to when
sending a new revision of a patch to keep them in the same thread and
allow us to understand the progress.
I plan to do an automatic nack for patches missing the --in-reply-to.