From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH] vhost: remove vhost-net requirements from generic vhost APIs Date: Wed, 27 Feb 2019 09:31:19 +0100 Message-ID: <39ad2842-9763-1521-089d-2cd2e98d9f08@redhat.com> References: <20190224233555.31304-1-darek.stojaczyk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: Darek Stojaczyk To: Dariusz Stojaczyk , dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 167C42B87 for ; Wed, 27 Feb 2019 09:31:22 +0100 (CET) In-Reply-To: <20190224233555.31304-1-darek.stojaczyk@gmail.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/25/19 12:35 AM, Dariusz Stojaczyk wrote: > From: Darek Stojaczyk > > The rte_vhost API to put data into virtqueues operates > on mbufs and hence it is strictly vhost-net specific. > External backends need to implement virtqueue handling > from scratch and that's just not possible without APIs > to get/set vring base addresses. > > Those relevant APIs are there, but they have a check that > prevents them from working with any non-vhost-net device. > This patch removes those checks. > > rte_vhost_get_log_base() is not necessarily needed for > external backends, as other, higher level vhost APIs for > live migration are available and could be used instead. > We remove the extra check from it anyway for consistency. > > Signed-off-by: Darek Stojaczyk > --- > lib/librte_vhost/vhost.c | 21 --------------------- > 1 file changed, 21 deletions(-) > Applied to dpdk-next-virtio/master. Thanks, Maxime