From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ilya Matveychikov Subject: [PATCH] mbuf: cleanup rte_pktmbuf_lastseg(), remove useless variable Date: Tue, 14 Nov 2017 17:44:49 +0400 Message-ID: <3DBFD712-8DA6-4FDB-B139-66398039B4C0@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable To: dev@dpdk.org Return-path: Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by dpdk.org (Postfix) with ESMTP id A0C002BB4 for ; Tue, 14 Nov 2017 14:44:52 +0100 (CET) Received: by mail-wm0-f67.google.com with SMTP id n74so18006944wmi.1 for ; Tue, 14 Nov 2017 05:44:52 -0800 (PST) Received: from [10.61.0.167] (bba193485.alshamil.net.ae. [217.165.96.191]) by smtp.gmail.com with ESMTPSA id m23sm18179910edc.53.2017.11.14.05.44.50 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 14 Nov 2017 05:44:51 -0800 (PST) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fixes: af75078fece3 ("first public release") Cc: intel.com Signed-off-by: Ilya V. Matveychikov --- There is no reason to have local variable m2 or am I wrong? lib/librte_mbuf/rte_mbuf.h | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h index 7e326bbc2..be79e3728 100644 --- a/lib/librte_mbuf/rte_mbuf.h +++ b/lib/librte_mbuf/rte_mbuf.h @@ -1538,12 +1538,10 @@ static inline uint16_t = rte_pktmbuf_tailroom(const struct rte_mbuf *m) */ static inline struct rte_mbuf *rte_pktmbuf_lastseg(struct rte_mbuf *m) { - struct rte_mbuf *m2 =3D (struct rte_mbuf *)m; - __rte_mbuf_sanity_check(m, 1); - while (m2->next !=3D NULL) - m2 =3D m2->next; - return m2; + while (m->next !=3D NULL) + m =3D m->next; + return m; } /** -- 2.15.0=