From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dumitrescu, Cristian" Subject: Re: [PATCH] cfgfile: fix uninitialized variable on load error Date: Tue, 14 Feb 2017 16:46:47 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891265274CEFD@IRSMSX108.ger.corp.intel.com> References: <1486435866-30562-1-git-send-email-bombermag@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To: Dmitriy Yakovlev , "dev@dpdk.org" Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 8A4F41077 for ; Tue, 14 Feb 2017 17:47:47 +0100 (CET) In-Reply-To: <1486435866-30562-1-git-send-email-bombermag@gmail.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Dmitriy Yakovlev > Sent: Tuesday, February 7, 2017 2:51 AM > To: dev@dpdk.org > Cc: Dmitriy Yakovlev > Subject: [dpdk-dev] [PATCH] cfgfile: fix uninitialized variable on load e= rror >=20 > Uninitialized scalar variable. Using uninitialized value cfg- > >sections[curr_section]->num_entries when calling rte_cfgfile_close. > And memory in variables cfg->sections[curr_section], sect- > >entries[curr_entry] maybe not equal NULL. We must decrement counters > curr_section, curr_entry when failed to realloc. >=20 > Fixes: eaafbad419bf ("cfgfile: library to interpret config files") >=20 > Signed-off-by: Dmitriy Yakovlev > --- > lib/librte_cfgfile/rte_cfgfile.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 Acked-by: Cristian Dumitrescu