From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Dumitrescu, Cristian" Subject: Re: [PATCH] net/i40e: fix hierarchy commit check Date: Wed, 26 Jul 2017 15:17:24 +0000 Message-ID: <3EB4FA525960D640B5BDFFD6A3D891267BA85561@IRSMSX108.ger.corp.intel.com> References: <1501080219-68567-1-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Lu, Wenzhuo" To: "Lu, Wenzhuo" , "dev@dpdk.org" Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 942E87CCD for ; Wed, 26 Jul 2017 17:17:28 +0200 (CEST) In-Reply-To: <1501080219-68567-1-git-send-email-wenzhuo.lu@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wenzhuo Lu > Sent: Wednesday, July 26, 2017 3:44 PM > To: dev@dpdk.org > Cc: Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH] net/i40e: fix hierarchy commit check >=20 > If there's no Traffic Management node added. Not > necessary to check if TM is committed. >=20 > Fixes: cac29c3c00a4 ("net/i40e: support committing TM hierarchy") > Signed-off-by: Wenzhuo Lu > --- > drivers/net/i40e/i40e_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde= v.c > index 9fcccda..042bcc1 100644 > --- a/drivers/net/i40e/i40e_ethdev.c > +++ b/drivers/net/i40e/i40e_ethdev.c > @@ -2033,7 +2033,7 @@ static inline void i40e_GLQF_reg_init(struct > i40e_hw *hw) >=20 > i40e_filter_restore(pf); >=20 > - if (!pf->tm_conf.committed) > + if (pf->tm_conf.root && !pf->tm_conf.committed) > PMD_DRV_LOG(WARNING, > "please call hierarchy_commit() " > "before starting the port"); > -- > 1.9.3 Acked-by: Cristian Dumitrescu