From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: Re: [PATCH 01/56] net/sfc: libefx-based PMD stub sufficient to build and init Date: Fri, 25 Nov 2016 17:22:11 +0300 Message-ID: <3a2ecff9-eee0-a66d-e18e-a7a20abfc9f5@solarflare.com> References: <1479740470-6723-1-git-send-email-arybchenko@solarflare.com> <1479740470-6723-2-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit To: Ferruh Yigit , Return-path: Received: from nbfkord-smmo03.seg.att.com (nbfkord-smmo03.seg.att.com [209.65.160.84]) by dpdk.org (Postfix) with ESMTP id 176F158EB for ; Fri, 25 Nov 2016 15:22:23 +0100 (CET) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/25/2016 01:17 PM, Ferruh Yigit wrote: > On 11/24/2016 3:59 PM, Andrew Rybchenko wrote: >> On 11/23/2016 06:26 PM, Ferruh Yigit wrote: >>> On 11/21/2016 3:00 PM, Andrew Rybchenko wrote: >>>> The PMD is put into the sfc/efx subdirectory to have a place for >>>> the second PMD and library shared by both. >>>> >>>> Enable the PMD by default on supported configuratons. >>>> >>>> Reviewed-by: Andy Moreton >>>> Signed-off-by: Andrew Rybchenko >>>> --- >>>> MAINTAINERS | 6 ++ >>>> config/common_base | 6 ++ >>>> config/defconfig_arm-armv7a-linuxapp-gcc | 1 + >>>> config/defconfig_arm64-armv8a-linuxapp-gcc | 1 + >>>> config/defconfig_i686-native-linuxapp-gcc | 5 + >>>> config/defconfig_i686-native-linuxapp-icc | 5 + >>>> config/defconfig_ppc_64-power8-linuxapp-gcc | 1 + >>>> config/defconfig_tile-tilegx-linuxapp-gcc | 1 + >>>> config/defconfig_x86_64-native-linuxapp-icc | 5 + >>>> config/defconfig_x86_x32-native-linuxapp-gcc | 5 + >>>> doc/guides/nics/features/sfc_efx.ini | 10 ++ >>>> doc/guides/nics/index.rst | 1 + >>>> doc/guides/nics/sfc_efx.rst | 109 +++++++++++++++++++++ <...> >>> And you can add extra options here, please keep in mind that there are >>> three compiler supported right now: gcc, clang and icc. You may require >>> to add compiler and version checks.. >> I've tried to disable the driver build on ICC since we've never tested it. > I believe we don't support selective config per compiler. Currently if a > code is enabled by default, it should support compilation with all three > compilers. I thought that the following lines in config/defconfig_x86_64-native-linuxapp-icc do the job: # # Solarflare PMD build is not supported using icc toolchain # CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n >> I've failed to find list of compiler versions which must/should be checked. > That list is not clear as far as I know. Mostly version related fixes > added based on reported build errors. So you can leave as it is right > now, or can test with default compiler versions of some common > distributions. I see. Thanks. <...>