From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v6 1/2] net/bond: fixes for link properties
 management
Date: Thu, 6 Jul 2017 10:33:04 +0100
Message-ID: <3ae66a7d-dfe1-58f7-a53e-cf0a82f39201@intel.com>
References: <20170705170912.31346-1-declan.doherty@intel.com>
 <20170705185429.13591-1-declan.doherty@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Tomasz Kulasek <tomaszx.kulasek@intel.com>
To: Declan Doherty <declan.doherty@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id BBDFC2C27
 for <dev@dpdk.org>; Thu,  6 Jul 2017 11:33:07 +0200 (CEST)
In-Reply-To: <20170705185429.13591-1-declan.doherty@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/5/2017 7:54 PM, Declan Doherty wrote:
> From: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> 
> This patch fixes the management of link properties in the bonded device.
> 
> In all mode except mode 4 a bonded device link will default to reporting
> the link as full duplex and auto-neg. The link speed for a bond port is
> calculated on it's active slaves and the particular mode it is running
> in. The bonding link speed is reported based on the transmit link as in
> some modes link speed between egress/ingress is not symmetrical.
> 
> - round-robin, balance, 802.3ad, TLB and ALB modes all report the link
>   speed as the sum of the speed of each active slave.
> - active backup link speed is reported as the speed of the current
>   primary slave
> - broadcast is reported as the minimum of value of the active slaves
>   link speeds.
> 
> In mode 4 (link aggregation 802.3ad) the properties of the first slave
> added to the bonded device are slave and subsequent slaves are verified
> to have the same properties.
> 
> Finally in the bond_ethdev_lsc_event_callback function the link
> properties of the device are updated after any change to the number of
> active slaves.

Fixes: 2efb58cbab6e ("bond: new link bonding library")
Cc: stable@dpdk.org

> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>


Series applied to dpdk-next-net/master, thanks.

(Signed-off from Tomasz, exists in older versions, added back)