From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [PATCH 2/4] eventdev: add caps API and PMD callbacks
 for eth Tx adapter
Date: Mon, 16 Jul 2018 11:25:45 +0530
Message-ID: <3afb2709-b081-92ef-41ff-a450de482923@intel.com>
References: <1530859329-160189-1-git-send-email-nikhil.rao@intel.com>
 <1530859329-160189-2-git-send-email-nikhil.rao@intel.com>
 <20180710105644.GA6792@ltp-pvn>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
 jerin.jacob@caviumnetworks.com, olivier.matz@6wind.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id C484623C
 for <dev@dpdk.org>; Mon, 16 Jul 2018 07:55:49 +0200 (CEST)
In-Reply-To: <20180710105644.GA6792@ltp-pvn>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>


On 7/10/2018 4:26 PM, Pavan Nikhilesh wrote:
> +int __rte_experimental
> +rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint32_t *caps)
> +{
> The caps get API needs to be similar to rx adapter caps get i.e. it needs to
> have the eth_port_id as a parameter so that the underlying event dev driver can
> expose INTERNAL PORT capability as not all ethdev drivers have the capability
> to interact with the eventdevs internal port.
>
> rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
> 			uint32_t *caps);
Hi Pavan,

Is querying the INTERNAL PORT on a per ethdev basis useful to the 
application ?

For e.g., the txa_init() function in the adapter implementation can only 
decide to use the internal port if it is supported for all ethdevs, 
hence I left that upto the eventdev PMD to decide - i.e., it could 
iterate across txa->dev_count eth devices to make that determination. 
For caps in general, I agree it makes sense to pass in the ethdev, but 
the INTERNAL PORT didn't seem useful on a per ethdev basis.

We could also replace caps_get with something like a
rte_event_eth_tx_adapter_internal_port_check(dev_id) and add a per 
ethdev caps if needed later.

Thanks,
Nikhil