From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH] ethdev: fix applications failure on configure Date: Tue, 1 May 2018 15:08:24 +0100 Message-ID: <3b002b01-7baa-cd51-cfbe-a70e8b5a0ae1@intel.com> References: <20180501133343.125260-1-ferruh.yigit@intel.com> <14979049.G4nOY0bchV@xps> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org To: Thomas Monjalon , xuemingl@mellanox.com Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 1FB85DED for ; Tue, 1 May 2018 16:08:26 +0200 (CEST) In-Reply-To: <14979049.G4nOY0bchV@xps> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/1/2018 3:01 PM, Thomas Monjalon wrote: > 01/05/2018 15:33, Ferruh Yigit: >> Many sample applications fail because of >> dev_info.flow_type_rss_offloads check in rte_eth_dev_configure() > > We need to define the API behaviour in doxygen. > >> The sample applications need to be fixed/updated before returning error >> on rte_eth_dev_configure() >> >> This patch keeps the error log but removes returning error. > > If the doc is updated in 18.05, we can have a deprecation notice > to insert the error return in 18.08. +1 to add a deprecation notice for this release and do the error return on 18.08. Is the doc update you mentioned doxygen update? Who can do doc update and deprecation notice patches for this release? > >> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check") >> Cc: xuemingl@mellanox.com >> >> Signed-off-by: Ferruh Yigit