From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Coquelin Subject: Re: [PATCH 2/4] net/virtio-user: fix the control vq support Date: Wed, 23 Jan 2019 23:07:53 +0100 Message-ID: <3b702e98-bb0e-ad8f-e311-91ad6893ebd7@redhat.com> References: <20190122170143.5650-1-tiwei.bie@intel.com> <20190122170143.5650-3-tiwei.bie@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 67AE02C36 for ; Wed, 23 Jan 2019 23:07:58 +0100 (CET) In-Reply-To: <20190122170143.5650-3-tiwei.bie@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/22/19 6:01 PM, Tiwei Bie wrote: > This patch fixed below issues in the packed ring based control > vq support in virtio user: > > 1. The idx_hdr should be used_idx instead of the id in the desc; > 2. We just need to write out a single used descriptor for each > descriptor list; > 3. The avail/used bits should be initialized to 0; > > Meanwhile, make the function name consistent with other parts. > > Fixes: 48a4464029a7 ("net/virtio-user: support control VQ for packed") > > Signed-off-by: Tiwei Bie > --- > drivers/net/virtio/virtio_ethdev.c | 11 ++++++ > .../net/virtio/virtio_user/virtio_user_dev.c | 37 +++++++++++-------- > drivers/net/virtio/virtio_user_ethdev.c | 7 +--- > 3 files changed, 34 insertions(+), 21 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime