From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCHv5 03/33] drivers/common/dpaa2: adding qbman
	driver
Date: Fri, 20 Jan 2017 10:18:51 +0530
Message-ID: <3b85b9ed-3c01-c400-00f3-05ff26e042c3@nxp.com>
References: <1484679174-4174-1-git-send-email-hemant.agrawal@nxp.com>
 <1484832240-2048-1-git-send-email-hemant.agrawal@nxp.com>
 <1484832240-2048-6-git-send-email-hemant.agrawal@nxp.com>
 <2aee9218-f7b6-fe4d-d0a5-59b28d8a9149@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <thomas.monjalon@6wind.com>, <bruce.richardson@intel.com>,
 <shreyansh.jain@nxp.com>, <john.mcnamara@intel.com>,
 <jerin.jacob@caviumnetworks.com>, Geoff Thorpe <Geoff.Thorpe@nxp.com>, "Roy
 Pledge" <Roy.Pledge@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM01-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam01on0040.outbound.protection.outlook.com [104.47.34.40])
 by dpdk.org (Postfix) with ESMTP id 296122BA7
 for <dev@dpdk.org>; Fri, 20 Jan 2017 05:49:02 +0100 (CET)
In-Reply-To: <2aee9218-f7b6-fe4d-d0a5-59b28d8a9149@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/20/2017 12:37 AM, Ferruh Yigit wrote:
> On 1/19/2017 1:23 PM, Hemant Agrawal wrote:
>> QBMAN, is a hardware block which interfaces with the other
>> accelerating hardware blocks (For e.g., WRIOP) on NXP's DPAA2
>> SoC for queue, buffer and packet scheduling.
>>
>> This patch introduces a userspace driver for interfacing with
>> the QBMAN hw block.
>>
>> The qbman-portal component provides APIs to do the low level
>> hardware bit twiddling for operations such as:
>>       -initializing Qman software portals
>>       -building and sending portal commands
>>       -portal interrupt configuration and processing
>>
>> This same/similar code is used in kernel and compat file is used
>> to make it working in user space.
>>
>> Signed-off-by: Geoff Thorpe <Geoff.Thorpe@nxp.com>
>> Signed-off-by: Roy Pledge <Roy.Pledge@nxp.com>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>
> <...>
>
>> diff --git a/drivers/common/dpaa2/qbman/include/compat.h b/drivers/common/dpaa2/qbman/include/compat.h
>> new file mode 100644
>> index 0000000..d321cc6
>> --- /dev/null
>> +++ b/drivers/common/dpaa2/qbman/include/compat.h
>> @@ -0,0 +1,403 @@
>> +/* Copyright (c) 2008-2016 Freescale Semiconductor, Inc.
>> + * All rights reserved.
>
> Should this say "#   BSD LICENSE" ? As in other file comments..
> There are multiple this kind of usage.
>

I can add it as per convention followed  in DPDK.
We are generally not adding that as BSD LICENSE is self determined by 
the clauses.

>> + *
>> + * Redistribution and use in source and binary forms, with or without
>> + * modification, are permitted provided that the following conditions are met:
>> + *     * Redistributions of source code must retain the above copyright
>> + *	 notice, this list of conditions and the following disclaimer.
>> + *     * Redistributions in binary form must reproduce the above copyright
>> + *	 notice, this list of conditions and the following disclaimer in the
>> + *	 documentation and/or other materials provided with the distribution.
>> + *     * Neither the name of Freescale Semiconductor nor the
>> + *	 names of its contributors may be used to endorse or promote products
>> + *	 derived from this software without specific prior written permission.
>> + *
>
> <...>
>