From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH v2 27/32] net/i40e: change version number to support Linux VF Date: Wed, 7 Dec 2016 15:13:59 +0000 Message-ID: <3cc33a4b-d45f-0008-05fc-033df4ccb197@intel.com> References: <1480637533-37425-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-1-git-send-email-wenzhuo.lu@intel.com> <1481081535-37448-28-git-send-email-wenzhuo.lu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: "Chen Jing D(Mark)" To: Wenzhuo Lu , dev@dpdk.org Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 275592B96 for ; Wed, 7 Dec 2016 16:14:08 +0100 (CET) In-Reply-To: <1481081535-37448-28-git-send-email-wenzhuo.lu@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 12/7/2016 3:32 AM, Wenzhuo Lu wrote: > i40e PF host only support to work with DPDK VF driver, Linux > VF driver is not supported. This change will enhance in version > number returned. > > Current version info returned won't be able to be recognized > by Linux VF driver, change to values that both DPDK VF and Linux > driver can recognize. > > The expense is original DPDK host specific feature like > CFG_VLAN_PVID and CONFIG_VSI_QUEUES_EXT will not available. > > DPDK VF also can't identify host driver by version number returned. > It always assume talking with Linux PF. I guess you mention from following code [1], should it be also updated to prevent it giving wrong information: [1] i40e_ethdev_vf.c if (vf->version_major == I40E_DPDK_VERSION_MAJOR) PMD_DRV_LOG(INFO, "Peer is DPDK PF host"); else if ((vf->version_major == I40E_VIRTCHNL_VERSION_MAJOR) && (vf->version_minor <= I40E_VIRTCHNL_VERSION_MINOR)) PMD_DRV_LOG(INFO, "Peer is Linux PF host"); else { > > Signed-off-by: Chen Jing D(Mark) > --- <...>