From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F26BC433DF for ; Sat, 22 Aug 2020 00:43:49 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 2BD312072D for ; Sat, 22 Aug 2020 00:43:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2BD312072D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B3D42B91; Sat, 22 Aug 2020 02:43:48 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1B56B29D2 for ; Sat, 22 Aug 2020 02:43:45 +0200 (CEST) IronPort-SDR: nL+5XjVg1z9y/Obd792O52GQ9X04bgLSAFIuPx2+YIa9dwHNshaHO9ZR17Z2fw8tvuKq9/9hrz qPggR2pX8sxQ== X-IronPort-AV: E=McAfee;i="6000,8403,9720"; a="153260365" X-IronPort-AV: E=Sophos;i="5.76,339,1592895600"; d="scan'208";a="153260365" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2020 17:43:45 -0700 IronPort-SDR: S8LaHREarIemqeQH8AwZFuA/OeysUvZXboQJ5audGLR+0chhaobG/DUS52omB1zjEO/9CWRD2L S+HMasg3dO8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,339,1592895600"; d="scan'208";a="293984923" Received: from orsmsx601-2.jf.intel.com (HELO ORSMSX601.amr.corp.intel.com) ([10.22.229.81]) by orsmga003.jf.intel.com with ESMTP; 21 Aug 2020 17:43:44 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 21 Aug 2020 17:43:44 -0700 Received: from orsmsx101.amr.corp.intel.com (10.22.225.128) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 21 Aug 2020 17:43:44 -0700 Received: from [10.166.30.253] (10.166.30.253) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 21 Aug 2020 17:43:43 -0700 To: Dmitry Kozlyuk , CC: Jie Zhou , Olivier Matz , Wenzhuo Lu , Beilei Xing , Bernard Iremonger , Ori Kam , Marko Kovacevic , "Bruce Richardson" , Radu Nicolau , Akhil Goyal , Tomasz Kantecki , Sunil Kumar Kori , "Pavan Nikhilesh" , Cristian Dumitrescu , Jasvinder Singh , David Hunt References: <20200821184855.2220-1-dmitry.kozliuk@gmail.com> From: Ranjit Menon Message-ID: <3cc84b36-0c75-f8fb-dedc-dae49f958bd7@intel.com> Date: Fri, 21 Aug 2020 17:43:43 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20200821184855.2220-1-dmitry.kozliuk@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [10.166.30.253] Subject: Re: [dpdk-dev] [PATCH] cmdline: avoid name clash with Windows system types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/21/2020 11:48 AM, Dmitry Kozlyuk wrote: > cmdline_numtype member names clash with Windows system identifiers. > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > future conflicts. > > Signed-off-by: Dmitry Kozlyuk > Suggested-by: Ranjit Menon > --- > > This patch made some lines overlong. When breaking them, indentation > style is kept consistent with nearby code; it's weird in some places. > > app/test-cmdline/commands.c | 2 +- > app/test-pmd/bpf_cmd.c | 10 +- > app/test-pmd/cmdline.c | 715 ++++++++++-------- > app/test-pmd/cmdline_flow.c | 2 +- > app/test-pmd/cmdline_mtr.c | 92 ++- > app/test-pmd/cmdline_tm.c | 177 ++--- > app/test/test_cmdline_num.c | 48 +- > examples/ethtool/ethtool-app/ethapp.c | 19 +- > examples/ipsec-secgw/parser.c | 2 +- > examples/qos_sched/cmdline.c | 46 +- > .../guest_cli/vm_power_cli_guest.c | 2 +- > examples/vm_power_manager/vm_power_cli.c | 8 +- > lib/librte_cmdline/cmdline_parse_num.c | 65 +- > lib/librte_cmdline/cmdline_parse_num.h | 16 +- > 14 files changed, 627 insertions(+), 577 deletions(-) > > Thanks for doing this, Dmitry! Acked-by: Ranjit Menon