From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [RFC] ethdev: add generic L2/L3 tunnel encapsulation
 actions
Date: Thu, 23 Aug 2018 13:12:30 +0100
Message-ID: <3cd2ce39-60c4-4738-3b44-76323ba1392d@intel.com>
References: <1532967565-13962-1-git-send-email-orika@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Ori Kam <orika@mellanox.com>, xuemingl@mellanox.com, dekelp@mellanox.com,
 shahafs@mellanox.com, thomas@monjalon.net, yskoh@mellanox.com,
 arybchenko@solarflare.com, dev@dpdk.org
To: adrien.mazarguil@6wind.com,
 "Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>,
 Declan Doherty <declan.doherty@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id 1847098
 for <dev@dpdk.org>; Thu, 23 Aug 2018 14:12:37 +0200 (CEST)
In-Reply-To: <1532967565-13962-1-git-send-email-orika@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 7/30/2018 5:19 PM, Ori Kam wrote:
> Currenlty the encap/decap actions only support encapsulation
> of VXLAN and NVGRE L2 packets.
> There is a need to add more L2 tunnels and also L3 tunnels.
> 
> One issue with the current approch is the duplication of code.
> For example the code for handling NVGRE and VXLAN are exactly the same,
> and each new tunnel will have the same exact structure.
> 
> Last issue with the current approach is the use of rte_items.
> The most significant issue with that is that the PMD needs to convert
> the items and this hurts the insertion rate. Other issue is that
> the rte_item has 3 members while we only need the spec (last and mask
> are useless). I know that the extra member have only small memory
> impact but considering that we can have millions of rules, this became
> more important consideration, and it is bad practice to add a variable
> that is never used.
> 
> My suggestion is to create 2 commands, one for encapsulation of L2
> packets and one for encapsulation of L3 tunnels.
> The parameters for those functions will be a uint8_t buffer with
> a length parameter.
> 
> The current approach is not implemented yet in drivers yet, and
> is marked as experimental, so it should be removed.
> 
> Any comments will be hugely appreciated.
> 
> Signed-off-by: Ori Kam <orika@mellanox.com>

Hi Adrien, Awal, Declan,

Any comment on the RFC?

Thanks,
ferruh