From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2 20/25] bnxt: add support to get and clear
 VF specific stats
Date: Mon, 29 May 2017 18:43:47 +0100
Message-ID: <3d568535-8eda-d79f-bbe5-43f9f1071184@intel.com>
References: <CACZ4nhuCdAoJJtmi2joaHf9+4+MzVFz87S-XO_J-HRBGUdiEFg@mail.gmail.com>
 <20170526183941.80678-1-ajit.khaparde@broadcom.com>
 <20170526183941.80678-21-ajit.khaparde@broadcom.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: Stephen Hurd <stephen.hurd@broadcom.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id D42357CBF
 for <dev@dpdk.org>; Mon, 29 May 2017 19:43:49 +0200 (CEST)
In-Reply-To: <20170526183941.80678-21-ajit.khaparde@broadcom.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/26/2017 7:39 PM, Ajit Khaparde wrote:
> This patch adds code to get and clear VF stats.
> It also adds the necessary HWRM structures to send the command
> to the firmware.
> 
> Signed-off-by: Stephen Hurd <stephen.hurd@broadcom.com>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 
> --
> v1->v2: regroup related patches and incorporate other review comments
> ---
>  drivers/net/bnxt/bnxt_hwrm.c    | 38 ++++++++++++++++++
>  drivers/net/bnxt/bnxt_hwrm.h    |  3 ++
>  drivers/net/bnxt/rte_pmd_bnxt.c | 87 +++++++++++++++++++++++++++++++++++++++++
>  drivers/net/bnxt/rte_pmd_bnxt.h | 64 ++++++++++++++++++++++++++++++
>  4 files changed, 192 insertions(+)

It looks like new APIs not added into .map file.
This doesn't cause a build error because they are not used anywhere,
that is why using testpmd to implement them helps to find any issues.

<...>

> +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count)
> +{
> +	struct rte_eth_dev *dev;
> +	struct rte_eth_dev_info dev_info;
> +	struct bnxt *bp;
> +
> +	dev = &rte_eth_devices[port];
> +	rte_eth_dev_info_get(port, &dev_info);
> +	bp = (struct bnxt *)dev->data->dev_private;
> +
> +	return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count);
> +}

This function is not to get VF stats from PF. As far as I can see this
just gets queue stats, does this really needs to be PMD specific API,
isn't this something generic?

<...>