From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v2] ethdev: add return value to stats get dev
 op
Date: Wed, 11 Oct 2017 03:09:18 +0100
Message-ID: <3da5949d-71d1-43d9-1583-c5d401ee0bcb@intel.com>
References: <1507565524-18590-1-git-send-email-matan@mellanox.com>
 <1507666818-3784-1-git-send-email-matan@mellanox.com>
 <157d75ef-01d0-6aca-81ec-c69bce2360c1@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Matan Azrad <matan@mellanox.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id D247C1B1B9
 for <dev@dpdk.org>; Wed, 11 Oct 2017 04:09:19 +0200 (CEST)
In-Reply-To: <157d75ef-01d0-6aca-81ec-c69bce2360c1@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/11/2017 3:01 AM, Ferruh Yigit wrote:
> On 10/10/2017 9:20 PM, Matan Azrad wrote:
>> The stats_get dev op API doesn't include return value, so PMD cannot
>> return an error in case of failure at stats getting process time.
>>
>> Since PCI devices can be removed and there is a time between the
>> physical removal to the RMV interrupt, the user may get invalid stats
>> without any indication.
>>
>> This patch changes the stats_get API return value to be int instead of
>> void.
>>
>> All the net PMDs stats_get dev ops are adjusted by this patch.
>>
>> Signed-off-by: Matan Azrad <matan@mellanox.com>
> 
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/master, thanks.