From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: patch for dpdk-devbind.py support ipv6
Date: Mon, 25 Jun 2018 10:19:12 +0100
Message-ID: <3e52a1e9-069d-124b-fd37-ea4c1bf2ef80@intel.com>
References: <AM4PR0501MB2355B83A8EE5A1B817D2E6E5A1760@AM4PR0501MB2355.eurprd05.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
To: Yaron Illouz <yaroni@radcom.com>, "dev@dpdk.org" <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by dpdk.org (Postfix) with ESMTP id 114572F7D
 for <dev@dpdk.org>; Mon, 25 Jun 2018 11:19:14 +0200 (CEST)
In-Reply-To: <AM4PR0501MB2355B83A8EE5A1B817D2E6E5A1760@AM4PR0501MB2355.eurprd05.prod.outlook.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 21-Jun-18 3:51 PM, Yaron Illouz wrote:
> Hi
> 
> dpdk-devbind.py support only ipv4 interface, when run with -s parameter which is  status, it display all ipv6 interface as non Active
> It set interface as Active according to "ip -o route" output
> Here is a change that can support ipv6
> 
> @@ -269,6 +269,18 @@
>       # filter out all lines for 169.254 routes
>       route = "\n".join(filter(lambda ln: not ln.startswith("169.254"),
>                                route.decode().splitlines()))
> +
> +    routev6 = check_output(["ip", "-6", "-o", "route"])
> +    # filter out all lines for 169.254 routes
> +    routev6 = "\n".join(filter(lambda ln: not ln.startswith("unreachable") and not ln.startswith("fe80::/64"),
> +                             routev6.decode().splitlines()))
> +
> +    if len(routev6):
> +        if len(route):
> +            route = route+"\n"+routev6
> +        else:
> +            route = routev6
> +
>       rt_info = route.split()
>       for i in range(len(rt_info) - 1):
>           if rt_info[i] == "dev":
> @@ -654,3 +666,4 @@
> 
> 
> Yaron Illouz
> 

Hi Yaron,

Thanks for your patch. Please see DPDK contribution guidelines[1] [2] on 
how to properly send patches to DPDK community.

In short, the following three things will need to be fixed before we are 
able to consider this patch for inclusion into DPDK codebase:

1) We will need developer certification of origin (a Sign-off) before we 
can accept any code into DPDK
2) Patch will have to be properly formatted using git-format-patch and 
preferably sent via git-send-email
3) Patch will have to have a descriptive commit message

[1] https://www.dpdk.org/contribute/
[2] https://doc.dpdk.org/guides/contributing/patches.html

-- 
Thanks,
Anatoly