From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v5 4/8] bpf: introduce basic RX/TX BPF filters
Date: Wed, 9 May 2018 18:09:16 +0100
Message-ID: <3e999447-f61e-2c62-cc05-ecc3e695ef35@intel.com>
References: <1523630598-24606-2-git-send-email-konstantin.ananyev@intel.com>
 <1525437945-8207-5-git-send-email-konstantin.ananyev@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Konstantin Ananyev <konstantin.ananyev@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by dpdk.org (Postfix) with ESMTP id 83E8F1B755
 for <dev@dpdk.org>; Wed,  9 May 2018 19:09:19 +0200 (CEST)
In-Reply-To: <1525437945-8207-5-git-send-email-konstantin.ananyev@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 5/4/2018 1:45 PM, Konstantin Ananyev wrote:
> +/**
> + * Load BPF program from the ELF file and install callback to execute it
> + * on given RX port/queue.
> + *
> + * @param port
> + *   The identifier of the ethernet port
> + * @param queue
> + *   The identifier of the RX queue on the given port
> + * @param fname
> + *  Pathname for a ELF file.
> + * @param sname
> + *  Name of the executable section within the file to load.
> + * @return
> + *   Zero on successful completion or negative error code otherwise.
> + */
> +int rte_bpf_eth_rx_elf_load(uint16_t port, uint16_t queue,
> +	const struct rte_bpf_prm *prm, const char *fname, const char *sname,
> +	uint32_t flags);
> +
> +/**
> + * Load BPF program from the ELF file and install callback to execute it
> + * on given TX port/queue.
> + *
> + * @param port
> + *   The identifier of the ethernet port
> + * @param queue
> + *   The identifier of the TX queue on the given port
> + * @param fname
> + *  Pathname for a ELF file.
> + * @param sname
> + *  Name of the executable section within the file to load.
> + * @return
> + *   Zero on successful completion or negative error code otherwise.
> + */
> +int rte_bpf_eth_tx_elf_load(uint16_t port, uint16_t queue,
> +	const struct rte_bpf_prm *prm, const char *fname, const char *sname,
> +	uint32_t flags);

Doxygen is complaining about documented params for both functions, prm & flags
are missing.