From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH] net/ifc: add live migration support
Date: Fri, 21 Sep 2018 00:55:19 +0100
Message-ID: <3f10edab-be6d-9e48-d022-e569ae79adc7@intel.com>
References: <20180910110123.138273-1-xiao.w.wang@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: dev@dpdk.org, xiaolong.ye@intel.com, zhihong.wang@intel.com,
 Chao Zhu <chaozhu@linux.vnet.ibm.com>
To: Xiao Wang <xiao.w.wang@intel.com>, tiwei.bie@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 649714C93
 for <dev@dpdk.org>; Fri, 21 Sep 2018 01:55:23 +0200 (CEST)
In-Reply-To: <20180910110123.138273-1-xiao.w.wang@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/10/2018 12:01 PM, Xiao Wang wrote:
> IFCVF can help to log dirty page in live migration stage,
> each queue's index can be read and configured to support
> VHOST_USER_GET_VRING_BASE and VHOST_USER_SET_VRING_BASE.
> 
> Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>

<...>

> +static void
> +ifcvf_used_ring_log(struct ifcvf_hw *hw, uint32_t queue, uint8_t *log_buf)
> +{
> +	uint32_t i, size;
> +	uint64_t pfn;
> +
> +	pfn = hw->vring[queue].used / PAGE_SIZE;
> +	size = hw->vring[queue].size * sizeof(struct vring_used_elem) +
> +			sizeof(__virtio16) * 3;

Getting a build error for PowerPC [1], can someone from PPC side confirm it please?

[1]
.../drivers/net/ifc/ifcvf_vdpa.c: In function ‘ifcvf_used_ring_log’:
.../drivers/net/ifc/ifcvf_vdpa.c:288:11: error: ‘__virtio16’ undeclared (first
use in this function)
    sizeof(__virtio16) * 3;
           ^~~~~~~~~~