DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marat Khalili <marat.khalili@huawei.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
	Sebti Mouelhi <sebti.mouelhi@huawei.com>,
	Konstantin Ananyev <konstantin.ananyev@huawei.com>,
	Marat Khalili <marat.khalili@huawei.com>
Subject: RE: [PATCH] bpf/validate: fix 32-bit BPF_AND/OR/XOR shift UBs
Date: Tue, 25 Aug 2026 11:06:43 +0000	[thread overview]
Message-ID: <3f1e8b3ad7d94ba7b8cef46be591698a@huawei.com> (raw)
In-Reply-To: <20260825095530.41354-1-marat.khalili@huawei.com>

Answering the multiple AI reviews (why are there 3 of them, all via Claude?):


1. Test naming

> +/* 32-bit bitwise AND between a scalar range and immediate, triggering UB. */
> +static int
> +test_alu32_and_k_ub(void)

I agree with the AI that test names (and comments) are somewhat minimalist and
would require reader to check the commit message to find out what's going on.
The suggestion by AI to replace `_ui` with `_range` is not improving things
much however, so only doing it to placate the AI in case of another iteration.

As far as I know DPDK does not have a strict policy for cross-referencing bugs,
fixes and tests, so in the interest of time and code brevity not putting a huge
effort into it unless asked by actual humans.


2. Test coverage

Not contesting that current test coverage of these instructions is rudimentary
and needs to be expanded; 32-bit instructions as a whole need a lot of work.
It is all out of scope of this patch however, the added tests are sufficient
for reproducing the specific bug and confirming the fix.


Not addressing the rest of AI comments, they are all non-issues IMO.

  reply	other threads:[~2026-08-25 11:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25  9:55 [PATCH] bpf/validate: fix 32-bit BPF_AND/OR/XOR shift UBs Marat Khalili
2026-08-25 11:06 ` Marat Khalili [this message]
2026-10-15 21:48 ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f1e8b3ad7d94ba7b8cef46be591698a@huawei.com \
    --to=marat.khalili@huawei.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=sebti.mouelhi@huawei.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox